Python: add OBJECT ENCODING command #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
force-pushed
the
python/integ_acongo_object_encoding
branch
from
3616989
to
c73a737
Compare
Yury-Fridlyand
approved these changes
May 27, 2024
| @@ -3347,7 +3420,7 @@ async def test_multi_key_command_returns_cross_slot_error( | |||
| redis_client.sdiffstore("abc", ["def", "ghi"]), | |||
| ] | |||
|
|
|||
| if not check_if_server_version_lt(redis_client, "7.0.0"): | |||
| if not await check_if_server_version_lt(redis_client, "7.0.0"): | |||
There was a problem hiding this comment.
How it worked before?
There was a problem hiding this comment.
From the Python docs:
In the context of Boolean operations, and also when expressions are used by control flow statements, the following values are interpreted as false: False, None, numeric zero of all types, and empty strings and containers (including strings, tuples, lists, dictionaries, sets and frozensets). All other values are interpreted as true.
Before this change, the call to the function (without the await) was returning a reference to a Couroutine object, so this branch was never actually being entered.
There was a problem hiding this comment.
So test never tested 🤦 🤦 🤦
cyip10
approved these changes
May 27, 2024
acarbonetto
approved these changes
May 27, 2024
Elen-Ghulam
approved these changes
May 27, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Python: add OBJECT ENCODING command (#308)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/object-encoding/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.