Core: Update XREAD value_conversion to return Map<Map<String[]>>
#1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
changed the title
XREAD value_conversion to return Map<Map<String[]>>
yipin-chen
approved these changes
May 29, 2024
|
Is return type |
aaron-congo
reviewed
May 30, 2024
aaron-congo
reviewed
May 30, 2024
aaron-congo
reviewed
May 30, 2024
Yury-Fridlyand
approved these changes
May 31, 2024
|
Rust CI fails. |
acarbonetto
force-pushed
the
java/integ_acarbo_add_xread_value_conversion
branch
from
89e7529
to
e31c756
Compare
barshaul
reviewed
Jun 3, 2024
| /// If `None` is given, then the key is not converted. | ||
| /// `value_type` is used to convert each value when collecting into the resulting map. | ||
| /// If `None` is given, then the value is not converted. | ||
| fn convert_inner_map_by_type( |
There was a problem hiding this comment.
isn't it the same as Yuri did in #1489 in convert_map_entries? please reuse it
There was a problem hiding this comment.
It is similar. Although this PR is much more general since it applies to, and can override all existing Map conversions.
barshaul
reviewed
Jun 3, 2024
barshaul
reviewed
Jun 3, 2024
barshaul
approved these changes
Jun 3, 2024
jonathanl-bq
approved these changes
Jun 3, 2024
acarbonetto
force-pushed
the
java/integ_acarbo_add_xread_value_conversion
branch
from
f078f04
to
1617da0
Compare
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
java/integ_acarbo_add_xread_value_conversion
branch
from
1617da0
to
e956bb6
Compare
Signed-off-by: Andrew Carbonetto <[email protected]>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
…alkey-io#1494) * Update XREAD to read a Map of Map Signed-off-by: Andrew Carbonetto <[email protected]> * Add changelog Signed-off-by: Andrew Carbonetto <[email protected]> * Fix test Signed-off-by: Andrew Carbonetto <[email protected]> * Node lint Signed-off-by: Andrew Carbonetto <[email protected]> * cargo fmt Signed-off-by: Andrew Carbonetto <[email protected]> * Update CHANGELOG Signed-off-by: Andrew Carbonetto <[email protected]> * Change XREAD value_conversion to recursive maps Signed-off-by: Andrew Carbonetto <[email protected]> * Add Node examples for XREAD; minor updates to value_conversion Signed-off-by: Andrew Carbonetto <[email protected]> * XREAD to array pairs Signed-off-by: Andrew Carbonetto <[email protected]> * Core: XREAD returns array of pairs Signed-off-by: Andrew Carbonetto <[email protected]> * Node: XREAD change reponse to array of pairs Signed-off-by: Andrew Carbonetto <[email protected]> * Revert java changes Signed-off-by: Andrew Carbonetto <[email protected]> * Cargo fmt Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> * Add Map(none, none) test Signed-off-by: Andrew Carbonetto <[email protected]> * Update CHANGELOG Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Update XREAD value_conversion to return a Map<Map<String[]>> instead of a Map<String[String[]]>.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.