Python: add FCALL_RO command #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jduo
reviewed
Jun 30, 2024
jduo
approved these changes
Jun 30, 2024
Yury-Fridlyand
approved these changes
Jun 30, 2024
yipin-chen
force-pushed
the
python/dev_yipin_fcall_ro
branch
from
37effe4
to
3798384
Compare
jonathanl-bq
reviewed
Jul 1, 2024
yipin-chen
force-pushed
the
python/dev_yipin_fcall_ro
branch
from
47746ee
to
b731dc1
Compare
Elen-Ghulam
approved these changes
Jul 1, 2024
yipin-chen
force-pushed
the
python/dev_yipin_fcall_ro
branch
from
f5798da
to
4ba1c6e
Compare
Yury-Fridlyand
approved these changes
Jul 1, 2024
acarbonetto
approved these changes
Jul 1, 2024
yipin-chen
force-pushed
the
python/dev_yipin_fcall_ro
branch
from
17a2cd3
to
a772e6c
Compare
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jul 16, 2024
* Python: add FCALL_RO command * Updated CHANGELOG.md * Renamed cluster fcall_ro to fcall_ro_route to address review comments * Modified tests with correct encoding type * Addressed review comment * Fixed encode issue in transacation test * Changed return type to Optional * Reverted changes of Optional return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/docs/latest/commands/fcall_ro/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.