Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: add examples #1925

Merged
merged 19 commits into from
Jul 29, 2024
Merged

Java: add examples #1925

merged 19 commits into from
Jul 29, 2024

Conversation

yipin-chen
Copy link
Collaborator

No description provided.

@yipin-chen yipin-chen requested a review from a team as a code owner July 11, 2024 21:46
@yipin-chen
Updated and resolved merge conflicts
a03e6ed 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen
Addressed review comment
bc28356 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen
Updated README.md
e95905f 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen
Updated standalone port
f732e43 
Signed-off-by: Yi-Pin Chen <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added java issues and fixes related to the java client docs Documentation labels Jul 11, 2024
aaron-congo
aaron-congo reviewed Jul 12, 2024
View reviewed changes
examples/java/src/main/java/glide/examples/ClusterExample.java Outdated Show resolved Hide resolved
examples/java/src/main/java/glide/examples/ClusterExample.java Outdated Show resolved Hide resolved
examples/java/src/main/java/glide/examples/ClusterExample.java Outdated Show resolved Hide resolved
examples/java/src/main/java/glide/examples/ClusterExample.java Outdated Show resolved Hide resolved
examples/java/src/main/java/glide/examples/StandaloneExample.java Outdated Show resolved Hide resolved
examples/java/src/main/java/glide/examples/StandaloneExample.java Outdated Show resolved Hide resolved
examples/java/src/main/java/glide/examples/StandaloneExample.java Outdated Show resolved Hide resolved
examples/java/src/main/java/glide/examples/StandaloneExample.java Outdated Show resolved Hide resolved
examples/java/src/main/java/glide/examples/ClusterExample.java Outdated Show resolved Hide resolved
@yipin-chen
Addressed review comment
7a545be 
Signed-off-by: Yi-Pin Chen <[email protected]>
barshaul
barshaul reviewed Jul 14, 2024
View reviewed changes
examples/java/README.md Outdated Show resolved Hide resolved
barshaul
barshaul requested changes Jul 14, 2024
View reviewed changes
Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the standalone example for now. Please do the fixes and ping me to re-review it and the cluster mode too

@yipin-chen
Updated error handling
33b70fd 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen
Added tags and throws
a4adb1b 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen
Minor updates
87dcb9c 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen
Minor wording fix
308e6fd 
Signed-off-by: Yi-Pin Chen <[email protected]>
@barshaul barshaul mentioned this pull request Jul 18, 2024
Merged
barshaul
barshaul requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last round

@yipin-chen
Addressed comments
82bb473 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen
Removed un-used import
6a1b06d 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen yipin-chen requested a review from barshaul July 24, 2024 20:18
@yipin-chen
Copy link
Collaborator Author

@barshaul ready for re-review

@yipin-chen
Updated version to 1.+
36a592d 
Signed-off-by: Yi-Pin Chen <[email protected]>
barshaul
barshaul reviewed Jul 28, 2024
View reviewed changes
examples/java/README.md Outdated Show resolved Hide resolved
barshaul
barshaul approved these changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@barshaul barshaul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment (see inline).
Please fix, make sure that you run the examples and everything compiles and run as expected, and merge 🚀
also - please update the wiki with links to the examples as well : https://github.com/valkey-io/valkey-glide/wiki/Java-Wrapper

@yipin-chen
Updated README.md
afcc5eb 
Signed-off-by: Yi-Pin Chen <[email protected]>
@yipin-chen yipin-chen merged commit 054cc3d into valkey-io:main Jul 29, 2024
2 checks passed
@yipin-chen yipin-chen deleted the java/dev_yipin_new_examples branch July 29, 2024 23:23
@asafpamzn asafpamzn mentioned this pull request Aug 11, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@jonathanl-bq jonathanl-bq jonathanl-bq left review comments

@acarbonetto acarbonetto acarbonetto approved these changes

@barshaul barshaul barshaul approved these changes

@aaron-congo aaron-congo aaron-congo approved these changes

Assignees
No one assigned
Labels
docs Documentation java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yipin-chen @Yury-Fridlyand @aaron-congo @jonathanl-bq @barshaul @acarbonetto