Node: added FCALL and FCALL_RO commands #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
yipin-chen
commented
Jul 24, 2024
| /** | ||
| * Invokes a previously loaded read-only function. | ||
| * | ||
| * See https://valkey.io/commands/fcall/ for more details. |
There was a problem hiding this comment.
Valkey document currently doesn't list fcall_ro command.
yipin-chen
commented
Jul 24, 2024
| } else { | ||
| return createCommand(RequestType.FunctionFlush, []); | ||
| } | ||
| } |
There was a problem hiding this comment.
I just group all function commands together.
yipin-chen
commented
Jul 24, 2024
| @@ -13,6 +13,7 @@ import { Buffer, BufferWriter, Reader, Writer } from "protobufjs"; | |||
| import { | |||
| AggregationType, | |||
| ExpireOptions, | |||
| GeoUnit, | |||
There was a problem hiding this comment.
My VS Code automatically fix the order.
Signed-off-by: Yi-Pin Chen <[email protected]>
Yury-Fridlyand
approved these changes
Jul 24, 2024
acarbonetto
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://valkey.io/commands/fcall/