Add command ZRandMember #2013
Merged
Add command ZRandMember #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzhang-BQ
force-pushed
the
node/integ_tjz_zrandmember_valkey-88
branch
4 times, most recently
from
945db32
to
42bc183
Compare
shohamazon
reviewed
Jul 25, 2024
tjzhang-BQ
force-pushed
the
node/integ_tjz_zrandmember_valkey-88
branch
3 times, most recently
from
dde58fa
to
ddf2c97
Compare
This comment was marked as resolved.
This comment was marked as resolved.
added 4 commits
July 26, 2024 12:59
address comments Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
tjzhang-BQ
force-pushed
the
node/integ_tjz_zrandmember_valkey-88
branch
from
408a7e0
to
a8b3e71
Compare
added 2 commits
July 26, 2024 13:01
Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
acarbonetto
reviewed
Jul 26, 2024
| @@ -185,6 +185,7 @@ export type ReturnType = | |||
| | null | |||
| | boolean | |||
| | bigint | |||
| | Buffer | |||
There was a problem hiding this comment.
This is required to make the change in transaction tests
| * console.log(payload2); // Output: null | ||
| * ``` | ||
| */ | ||
| public async zrandmember(key: string): Promise<string | null> { |
There was a problem hiding this comment.
consider:
Suggested change
| public async zrandmember(key: string): Promise<string | null> { | |
| public async zrandmember(key: string, count?: number): Promise<string | null | string[]> { |
There was a problem hiding this comment.
let's not do this. just because we can merge signatures, it's not always the right thing to do.
it would reduce the number of commands we need to maintain, but it means we have to rely on the user reading and understanding the documentation
Signed-off-by: TJ Zhang <[email protected]>
Yury-Fridlyand
approved these changes
Jul 27, 2024
Signed-off-by: TJ Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.