Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Add ZLEXCOUNT command #2022

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Node: Add ZLEXCOUNT command #2022

merged 11 commits into from
Jul 31, 2024

Conversation

acarbonetto
Copy link
Collaborator

Add command ZLEXCOUNT

@acarbonetto acarbonetto added the node Node.js wrapper label Jul 26, 2024
@acarbonetto acarbonetto self-assigned this Jul 26, 2024
@acarbonetto acarbonetto requested a review from a team as a code owner July 26, 2024 15:50
Yury-Fridlyand
Yury-Fridlyand approved these changes Jul 26, 2024
View reviewed changes
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
aaron-congo
aaron-congo reviewed Jul 26, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/Transaction.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/tests/SharedTests.ts Outdated Show resolved Hide resolved
node/tests/TestUtilities.ts Outdated Show resolved Hide resolved
yipin-chen
yipin-chen reviewed Jul 26, 2024
View reviewed changes
node/src/Transaction.ts Outdated Show resolved Hide resolved
yipin-chen
yipin-chen reviewed Jul 26, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
@acarbonetto acarbonetto mentioned this pull request Jul 26, 2024
Merged
Yury-Fridlyand
Yury-Fridlyand reviewed Jul 27, 2024
View reviewed changes
node/src/Commands.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Show resolved Hide resolved
node/src/Commands.ts Show resolved Hide resolved
aaron-congo
aaron-congo approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@aaron-congo aaron-congo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor nits, and agree with Yury that the enum InfScoreBoundary needs to be added to npm/glide/index.ts, otherwise LGTM

node/src/Transaction.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
@acarbonetto acarbonetto force-pushed the node/integ_acarbo_add_zlexcount_valkey-89 branch from 44b4fdd to 9e74986 Compare July 31, 2024 20:29
@acarbonetto
Node: Add ZLEXCOUNT
9441bdb 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Update for self-review
d1e0188 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
JavaDoc cleanup
c736c4c 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
linter
bbce3cf 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Update for review
809251e 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Update for review
e4ae4fe 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Update infinity from string to enum
501acbe 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Doc fix
856a5ed 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
Add type to exports
0eefa9e 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto
linter
469a1f4 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto force-pushed the node/integ_acarbo_add_zlexcount_valkey-89 branch from 9e74986 to 469a1f4 Compare July 31, 2024 21:50
@acarbonetto
Remove import
68b2de3 
Signed-off-by: Andrew Carbonetto <[email protected]>
@acarbonetto acarbonetto merged commit d785b95 into valkey-io:main Jul 31, 2024
8 checks passed
@acarbonetto acarbonetto deleted the node/integ_acarbo_add_zlexcount_valkey-89 branch July 31, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

@aaron-congo aaron-congo aaron-congo approved these changes

Assignees

@acarbonetto acarbonetto

Labels
node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acarbonetto @aaron-congo @Yury-Fridlyand @yipin-chen