Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: FUNCTION DUMP and FUNCTION RESTORE in transaction #2173

Conversation

Yury-Fridlyand
Copy link
Collaborator

No description provided.

@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Aug 20, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner August 20, 2024 17:23
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although does it make sense to go with the Java solution for this?

CHANGELOG.md Outdated Show resolved Hide resolved
*
* @see {@link https://valkey.io/commands/function-dump/|valkey.io} for details.
* @remarks Since Valkey version 7.0.0.
* @remarks To execute a transaction with a `functionDump` command, the `exec` command requires `Decoder.Bytes` to handle the response.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were going to go with the same solution as Java?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we have a task for this

Co-authored-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand merged commit 56dead0 into valkey-io:main Aug 21, 2024
9 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/yuryf-function-dump-restore-traansaction branch August 21, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants