Node: Add binary variant to server management commands. #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
commented
Aug 21, 2024
| ): Promise<Record<string, string>> { | ||
| return this.createWritePromise(createConfigGet(parameters)); | ||
| decoder?: Decoder, | ||
| ): Promise<Record<string, GlideString>> { |
There was a problem hiding this comment.
I assume that config parameter names are defined by the server, so all of them are simple strings.
Can I assume that parameter values are simple strings as well?
| public async configSet(parameters: Record<string, string>): Promise<"OK"> { | ||
| return this.createWritePromise(createConfigSet(parameters)); | ||
| public async configSet( | ||
| parameters: Record<string, GlideString>, |
acarbonetto
approved these changes
Aug 22, 2024
node/src/Commands.ts
Outdated
| @@ -98,6 +98,15 @@ export type DecoderOption = { | |||
| decoder?: Decoder; | |||
| }; | |||
|
|
|||
| /** An extension to command option types with {@link Routes}. */ | |||
| export type RouteOption = { | |||
There was a problem hiding this comment.
Is this used in this file?
Maybe RouteOption should be defined in GlideClusterClient because it's not ever used here.
Thoughts?
Co-authored-by: Andrew Carbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
yipin-chen
approved these changes
Aug 23, 2024
liorsve
pushed a commit
to liorsve/valkey-glide
that referenced
this pull request
Aug 25, 2024
* Add binary variant to server management commands. Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
liorsve
pushed a commit
to liorsve/valkey-glide
that referenced
this pull request
Aug 25, 2024
* Add binary variant to server management commands. Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redis.io/docs/latest/commands/?group=server
ConfigGetConfigResetStatConfigRewriteConfigSetDbSizeFlushAllFlushDbInfoLastSaveLolwutTime