Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: fix BITPOS #2227

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Node: fix BITPOS #2227

wants to merge 14 commits into from

Conversation

cyip10
Copy link
Collaborator

@cyip10 cyip10 commented Sep 4, 2024

@cyip10 cyip10 marked this pull request as ready for review September 6, 2024 16:22
@cyip10 cyip10 requested a review from a team as a code owner September 6, 2024 16:22
acarbonetto
acarbonetto reviewed Sep 6, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Sep 6, 2024
Yury-Fridlyand
Yury-Fridlyand reviewed Sep 6, 2024
View reviewed changes
node/src/BaseClient.ts Outdated Show resolved Hide resolved
node/src/Commands.ts Outdated Show resolved Hide resolved
shohamazon
shohamazon previously requested changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@shohamazon shohamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for #2248 to be merged first

@Yury-Fridlyand Yury-Fridlyand added the Valkey-8 Support for Valkey-8 features label Sep 16, 2024
@Yury-Fridlyand Yury-Fridlyand linked an issue Sep 23, 2024 that may be closed by this pull request
Fix bitpos implementation for python and node #2343
Open
@asafpamzn asafpamzn added this to the 1.2 milestone Sep 30, 2024
cyip10 and others added 14 commits October 3, 2024 11:22
@cyip10 @jamesx-improving
implement node bitcount change
225ca77 
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 @jamesx-improving
added in examples in base client
c15aa0c 
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 @jamesx-improving
fix lint errors
7cbf041 
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 @jamesx-improving
fix linter issue
f3f0c4d 
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 @acarbonetto @jamesx-improving
fix spacing
f25049d 
Co-authored-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 @jamesx-improving
add function
372017b 
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 @jamesx-improving
fix lint errors
4ad74fa 
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 @jamesx-improving
fix createbitpos
6a36621 
Signed-off-by: Chloe Yip <[email protected]>
@cyip10 @jamesx-improving
add changelog
e3b6294 
Signed-off-by: Chloe Yip <[email protected]>
@Yury-Fridlyand @jamesx-improving
rebase
b284017 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand @jamesx-improving
rebase
aac1f40 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand @jamesx-improving
Signed-off-by: Yury-Fridlyand <[email protected]>
bae76f8
@jamesx-improving
make 'start' required for BitOffsetOptions
c8cb33b 
Signed-off-by: James Xin <[email protected]>
@jamesx-improving
post rebase clean up
4a0f735 
Signed-off-by: James Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesx-improving jamesx-improving jamesx-improving left review comments

@acarbonetto acarbonetto acarbonetto left review comments

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

@shohamazon shohamazon shohamazon left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
1_2_candidate node Node.js wrapper Valkey-8 Support for Valkey-8 features
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Fix bitpos implementation for python and node
6 participants
@cyip10 @Yury-Fridlyand @acarbonetto @shohamazon @jamesx-improving @asafpamzn