Fetch server version using info command #2258
Conversation
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
| String[] serverSectionArray = infoResponse.split("\n"); | ||
|
|
||
| for (int i = 0; i < serverSectionArray.length; i++) { | ||
| if (serverSectionArray[i].contains("redis_version")) { |
There was a problem hiding this comment.
Check for valkey version first
127.0.0.1:7000> info server
# Server
redis_version:7.2.4
server_name:valkey
valkey_version:7.9.240
There was a problem hiding this comment.
Updated.
| } | ||
|
|
||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Add a message, e.g. "failed to get server version"
There was a problem hiding this comment.
Updated.
|
|
||
| static { | ||
| try { | ||
| standaloneClient = GlideClient.createClient(commonClientConfig().build()).get(); |
There was a problem hiding this comment.
| standaloneClient = GlideClient.createClient(commonClientConfig().build()).get(); | |
| var standaloneClient = GlideClient.createClient(commonClientConfig().build()).get(); |
No need static lifetime for the client
There was a problem hiding this comment.
Updated.
| private static final GlideClient standaloneClient; | ||
| public static final Semver SERVER_VERSION; | ||
|
|
||
| static { |
There was a problem hiding this comment.
Please add a function to TestUtilities which runs info and parses the response. The function has one argument - client.
Then static block will call that function. Add @SneakyThrows to the function - we don't care about exceptions.
This could be used in some specific tests where we could have servers of different versions.
There was a problem hiding this comment.
Updated.
Moved function to TestUtilities.
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Updated. Used these 2 commands for linter check |
Signed-off-by: prateek-kumar-improving <[email protected]>
Signed-off-by: prateek-kumar-improving <[email protected]>
Creating a separate PR for this. |
* Fetch server version using info command Signed-off-by: Prateek Kumar <[email protected]>
Get server version using info command in TestConfiguration.java