Java: Replace instances of Redis with Valkey #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: jonathanl-bq <[email protected]>
GumpacG
approved these changes
Sep 10, 2024
yipin-chen
approved these changes
Sep 10, 2024
acarbonetto
approved these changes
Sep 11, 2024
java/benchmarks/src/main/java/glide/benchmarks/BenchmarkingApp.java
Outdated
Show resolved
Hide resolved
java/src/ffi_test.rs
Outdated
| @@ -14,8 +14,8 @@ pub extern "system" fn Java_glide_ffi_FfiTest_createLeakedNil<'local>( | |||
| _env: JNIEnv<'local>, | |||
| _class: JClass<'local>, | |||
| ) -> jlong { | |||
| let redis_value = Value::Nil; | |||
| Box::leak(Box::new(redis_value)) as *mut Value as jlong | |||
| let valkey_value = Value::Nil; | |||
There was a problem hiding this comment.
nit
Suggested change
| let valkey_value = Value::Nil; | |
| let resp_value = Value::Nil; |
Co-authored-by: Andrew Carbonetto <[email protected]> Signed-off-by: jonathanl-bq <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: jonathanl-bq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.