-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Fix byte GlideString conversion to String bug #2271
Merged
GumpacG
merged 7 commits into
valkey-io:main
from
Bit-Quill:java/integ_glidestring_tests_valkey-110
Sep 11, 2024
Merged
Java: Fix byte GlideString conversion to String bug #2271
GumpacG
merged 7 commits into
valkey-io:main
from
Bit-Quill:java/integ_glidestring_tests_valkey-110
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
force-pushed
the
java/integ_glidestring_tests_valkey-110
branch
from
September 11, 2024 15:31
3612356
to
4536917
Compare
acarbonetto
reviewed
Sep 11, 2024
acarbonetto
reviewed
Sep 11, 2024
GumpacG
changed the title
Java: Add test for GlideString
Java: Fix byte conversion to GlideString bug
Sep 11, 2024
GumpacG
force-pushed
the
java/integ_glidestring_tests_valkey-110
branch
from
September 11, 2024 20:34
4536917
to
d8d1ae2
Compare
GumpacG
changed the title
Java: Fix byte conversion to GlideString bug
Java: Fix byte GlideString conversion to String bug
Sep 11, 2024
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
GumpacG
force-pushed
the
java/integ_glidestring_tests_valkey-110
branch
from
September 11, 2024 20:38
4a14bbc
to
8b614fb
Compare
acarbonetto
approved these changes
Sep 11, 2024
Co-authored-by: Andrew Carbonetto <[email protected]> Signed-off-by: Guian Gumpac <[email protected]>
jonathanl-bq
approved these changes
Sep 11, 2024
Yury-Fridlyand
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please list which APIs (commands) you fixed in the PR description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug that incorrectly converts non UTF-8 bytes GlideString to String with the value
"Value not convertible to string: byte[] "
instead of throwing an exception.Affected APIs:
convertMapToKeyValueGlideStringArray:
public CompletableFuture<String> msetBinary(@NonNull Map<GlideString, GlideString> keyValueMap)
public CompletableFuture<Long> hset( @NonNull GlideString key, @NonNull Map<GlideString, GlideString> fieldValueMap)
public CompletableFuture<GlideString> xadd( @NonNull GlideString key, @NonNull Map<GlideString, GlideString> values, @NonNull StreamAddOptionsBinary options)
public CompletableFuture<Boolean> msetnxBinary( @NonNull Map<GlideString, GlideString> keyValueMap)
convertNestedArrayToKeyValueGlideStringArray:
public CompletableFuture<GlideString> xadd( @NonNull GlideString key, @NonNull GlideString[][] values, @NonNull StreamAddOptionsBinary options)
convertMapToValueKeyStringArrayBinary:
public CompletableFuture<Long> zadd( @NonNull GlideString key, @NonNull Map<GlideString, Double> membersScoresMap, @NonNull ZAddOptions options, boolean changed)
Reproduction steps for the bug:
Run
See the output to be
Value not convertible to string: byte[] 13
Expected
We expect an exception to be thrown in order to avoid unintended data to be stored in the server.