Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Use options for options. #2287

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Node: Use options for options. #2287

merged 2 commits into from
Sep 13, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Sep 13, 2024 •
edited
Loading

  1. Use options struct for all optional args for all commands
  2. Fix arg types for some stream commands

Purpose of this change:

  1. To align all API, especially across standalone and cluster clients and transaction
  2. If we don't release it in 1.1, that will be a breaking change
  3. Adding new optional argument won't be a breaking change for existing API

@Yury-Fridlyand
Use options for options.
00dbeac 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Sep 13, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner September 13, 2024 00:42
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Sep 13, 2024
Open
@acarbonetto acarbonetto merged commit d4803a4 into valkey-io:main Sep 13, 2024
15 checks passed
@acarbonetto acarbonetto deleted the node/yuryf-options branch September 13, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

Assignees
No one assigned
Labels
node Node.js wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yury-Fridlyand @acarbonetto