Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add missing exports #2321

Open
wants to merge 6 commits into
base: release-1.1
Choose a base branch
from

Conversation

Yury-Fridlyand
Copy link
Collaborator

Sibling of #2301

Signed-off-by: Yury-Fridlyand <[email protected]>
python/python/glide/__init__.py Outdated Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand linked an issue Sep 19, 2024 that may be closed by this pull request
@Yury-Fridlyand Yury-Fridlyand added this to the 1.1 milestone Sep 19, 2024
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add JSON types

python/python/glide/__init__.py Show resolved Hide resolved
python/python/glide/__init__.py Show resolved Hide resolved
python/python/glide/__init__.py Show resolved Hide resolved
@acarbonetto
Copy link
Collaborator

also, CI is red

@Yury-Fridlyand
Copy link
Collaborator Author

Added, CI fixed

Signed-off-by: Andrew Carbonetto <[email protected]>
This reverts commit a26ca32.

Signed-off-by: Andrew Carbonetto <[email protected]>
"TFunctionListResponse",
"TFunctionStatsFullResponse",
"TFunctionStatsSingleNodeResponse",
"TJsonResponse",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove, well add it when we add support for modules

Copy link
Collaborator

@shohamazon shohamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove anything related to json, we will add it when we add support for modules
approved by @ikolomi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python client has missing exports
5 participants