Python: adds TYPE command #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
reviewed
Feb 13, 2024
| key (str): The key to check its data type. | ||
|
|
||
| Returns: | ||
| Optional[str]: The type of value stored at `key`, or "none" when key doesn't exist. |
There was a problem hiding this comment.
ohh, I see, it doesn't response with None, but with a "none" string? if so, please change the return type documented here from Optional[str] to str
There was a problem hiding this comment.
Lets write it a bit clearer:
If the key exists, the type of the stored value is returned; otherwise, a "none" string is returned.
barshaul
reviewed
Feb 13, 2024
|
|
||
| Returns: | ||
| Optional[str]: The type of value stored at `key`, or "none" when key doesn't exist. | ||
| The different types that can be returned are: string, list, set, zset, hash and stream. |
There was a problem hiding this comment.
Lets remove this line as it would require us to maintain it with new types will be added to redis, and, also - when modules are being loaded we might have more types
barshaul
reviewed
Feb 13, 2024
| The different types that can be returned are: string, list, set, zset, hash and stream. | ||
|
|
||
| Examples: | ||
| >>> await client.type("my_key") |
There was a problem hiding this comment.
Lets expand the example a bit-
>>> await client.set("key", "value")
>>> await client.type("key")
'string'
barshaul
reviewed
Feb 13, 2024
barshaul
reviewed
Feb 13, 2024
| key (str): The key to check its data type. | ||
|
|
||
| Commands response: | ||
| Optional[str]: The type of value stored at `key`, or "none" when key doesn't exist. |
shohamazon
force-pushed
the
python/type
branch
from
e4f59df
to
d49a8a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.