Python: adds SISMEMBER command #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamazon
force-pushed
the
python/sismember
branch
2 times, most recently
from
31a61f6
to
7b647dd
Compare
barshaul
reviewed
Feb 18, 2024
| member (str): The member to check for existence in the set. | ||
|
|
||
| Returns: | ||
| int: 1 if the member exists in the set, 0 otherwise. |
There was a problem hiding this comment.
same as in the HSETNX PR - can we parse this command response in rust and return a boolean instead of an int?
barshaul
reviewed
Feb 18, 2024
|
|
||
| Returns: | ||
| int: 1 if the member exists in the set, 0 otherwise. | ||
| If `key` is not a set, it is treated an an empty set and the command returns 0. |
There was a problem hiding this comment.
If key is not a set, it is treated an an empty => If key is not a set, it is treated as an empty s
shohamazon
force-pushed
the
python/sismember
branch
from
7b647dd
to
b4d8c1b
Compare
barshaul
reviewed
Feb 28, 2024
barshaul
reviewed
Feb 28, 2024
barshaul
approved these changes
Feb 28, 2024
shohamazon
force-pushed
the
python/sismember
branch
from
b4d8c1b
to
b0fd360
Compare
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.