Python: adds ZPOPMIN command #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
reviewed
Feb 18, 2024
|
|
||
| Args: | ||
| key (str): The key of the sorted set. | ||
| count (Optional[int]): If not specified or None, pops one member. |
There was a problem hiding this comment.
missing the description of this arg. something like
Count: "Specifies the quantity of members to pop. If not specified, pops one member."
barshaul
reviewed
Feb 18, 2024
| If `count` is higher than the sorted set's cardinality, returns all members and their scores. | ||
|
|
||
| Returns: | ||
| Map[str, float]: A map of the removed members and their scores, ordered from the one with the lowest score to the one with the highest. |
barshaul
reviewed
Feb 18, 2024
| return cast( | ||
| Mapping[str, float], | ||
| await self._execute_command( | ||
| RequestType.ZPopMin, [key, str(count)] if count else [key] |
There was a problem hiding this comment.
what happens if count == 0 or a negative value? is it acceptable by redis?
There was a problem hiding this comment.
count == 0 returns an empty map, negative value will raise an error, Ill add a check
barshaul
reviewed
Feb 18, 2024
| @@ -1024,6 +1024,25 @@ def zcount( | |||
| """ | |||
| self.append_command(RequestType.Zcount, [key, min_score.value, max_score.value]) | |||
|
|
|||
| def zpopmin(self, key: str, count: Optional[int] = None): | |||
barshaul
approved these changes
Feb 18, 2024
shohamazon
force-pushed
the
python/zpopmin
branch
2 times, most recently
from
873ca72
to
778d67a
Compare
shohamazon
force-pushed
the
python/zpopmin
branch
from
778d67a
to
441c588
Compare
avifenesh
pushed a commit
to avifenesh/valkey-glide
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.