Python: Allow chaining function calls on transaction #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
reviewed
Feb 18, 2024
|
|
||
| @pytest.mark.parametrize("cluster_mode", [True, False]) | ||
| @pytest.mark.parametrize("protocol", [ProtocolVersion.RESP2, ProtocolVersion.RESP3]) | ||
| async def test_transaction_chaning_calls(self, redis_client: TRedisClient): |
There was a problem hiding this comment.
you don't need to write a test to handle this. Just change the existing transaction test to use chaining.
There was a problem hiding this comment.
the current one cant use chaining because we modified it to be more readable
barshaul
reviewed
Feb 18, 2024
| @@ -14,6 +14,8 @@ | |||
| ) | |||
| from glide.protobuf.redis_request_pb2 import RequestType | |||
|
|
|||
| T = TypeVar("T", bound="BaseTransaction") | |||
There was a problem hiding this comment.
minor:
change T to TTransaction
TTransaction = TypeVar("TTransaction", bound="BaseTransaction")
barshaul
reviewed
Feb 18, 2024
|
|
||
| @pytest.mark.parametrize("cluster_mode", [True, False]) | ||
| @pytest.mark.parametrize("protocol", [ProtocolVersion.RESP2, ProtocolVersion.RESP3]) | ||
| async def test_transaction_chaning_calls(self, redis_client: TRedisClient): |
barshaul
approved these changes
Feb 18, 2024
shohamazon
force-pushed
the
python/builder-transaction
branch
from
733d7ec
to
7ebce77
Compare
shohamazon
force-pushed
the
python/builder-transaction
branch
from
7ebce77
to
731eb9d
Compare
avifenesh
pushed a commit
to avifenesh/valkey-glide
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.