fix(select): issue #437 (#454)

* fix typing to input throwing an error and highlight on highlighting the first character * added rest of the highlight pipe usages
valor-software · Oct 5, 2016 · 926e14d · 926e14d
1 parent fa37202
commit 926e14d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/components/select/select-pipes.ts b/components/select/select-pipes.ts
@@ -3,13 +3,11 @@ import { escapeRegexp } from './common';
 
 @Pipe({name: 'highlight'})
 export class HighlightPipe implements PipeTransform {
-  public transform(value:string, args:any[]):any {
-    if (args.length < 1) {
+  public transform(value:string, query:string):any {
+    if (query.length < 1) {
       return value;
     }
 
-    let query = args[0];
-
     if ( query ) {
         let tagRE    = new RegExp('<[^<>]*>', 'ig');
         // get ist of tags

diff --git a/components/select/select.ts b/components/select/select.ts
@@ -143,7 +143,7 @@ let styles = `
                (mouseenter)="selectActive(o)"
                (click)="selectMatch(o, $event)">
             <a href="javascript:void(0)" class="dropdown-item">
-              <div [innerHtml]="sanitize(o.text) | highlight:inputValue"></div>
+              <div [innerHtml]="sanitize(o.text | highlight:inputValue)"></div>
             </a>
           </div>
         </li>
@@ -162,7 +162,7 @@ let styles = `
                (click)="selectMatch(o, $event)"
                [ngClass]="{'active': isActive(o)}">
             <a href="javascript:void(0)" class="dropdown-item">
-              <div [innerHtml]="sanitize(o.text) | highlight:inputValue"></div>
+              <div [innerHtml]="sanitize(o.text | highlight:inputValue)"></div>
             </a>
           </div>
         </li>
@@ -209,7 +209,7 @@ let styles = `
                (mouseenter)="selectActive(o)"
                (click)="selectMatch(o, $event)">
             <a href="javascript:void(0)" class="dropdown-item">
-              <div [innerHtml]="sanitize(o.text) | highlight:inputValue"></div>
+              <div [innerHtml]="sanitize(o.text | highlight:inputValue)"></div>
             </a>
           </div>
         </li>
@@ -228,7 +228,7 @@ let styles = `
                (click)="selectMatch(o, $event)"
                [ngClass]="{'active': isActive(o)}">
             <a href="javascript:void(0)" class="dropdown-item">
-              <div [innerHtml]="sanitize(o.text) | highlight:inputValue"></div>
+              <div [innerHtml]="sanitize(o.text | highlight:inputValue)"></div>
             </a>
           </div>
         </li>