fix issue #437 #454
Merged
fix issue #437 #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he first character
|
Can someone with write access merge this pull request ? |
|
Looks good to me! Thanks for helping |
|
Can I ask you when this fix will be realesed in master branch? Thank you! |
|
I need to process ng2-table PRs today and will get back ng2-select |
|
@valorkin We'd be extremely grateful if you could just release a patch version 1.1.1 for this since it is quite essential for our product. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes issue #437 and makes the highlighter to hightlight the whole text instead of just first character