-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for @angular/forms #631
Conversation
thank you very much. I will take a look at this later today. |
"@angular/platform-browser": "^2.0.0-rc.1", | ||
"@angular/platform-browser-dynamic": "^2.0.0-rc.1", | ||
"@angular/router-deprecated": "2.0.0-rc.1", | ||
"@angular/common": "^2.0.0-rc.2", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
@Dinistro and rebase is must, or cherry pick at least |
@jFensch Can you please rebase your branch to resolve the conflicts? |
@jFensch Thanks for the rebase but unfortunately some tests are not working, can you please fix them? |
@valorkin Now we need to do this by our own. Unluckily I have finals on monday and so I don't have time to do it right now. |
Recloning and fixing the tests...give me a minute. Sorry |
Hi guys :) Any idea when the broken 1.0.17 will be fixed? I'm getting the "No provider for NgModel" also, and can't move forward with my development. Would really appreciate this being fixed. |
i'm having same issue with rc4 |
Yeah, same here. Can't wait for the update. Thanks for your hard work as always guys! |
Yes, thank you for the hard work and commitment. All of us who are using the ng-bootstrap library really do appreciate it. We would not be able to move forward with Angular 2 without it! Please let us know about the status of this breakage so we can make plans accordingly. Much appreciated :) |
In order to use new forms you need to enable them: |
Don't work for me. Added
and used NgModel from @angular/forms. Still |
Just a heads up, it does work fine for me with 1.0.22. |
Oh, I see. I didn't test typeahead. |
This PR should resolve #627. Uses the new providers/directives from @angular/forms