Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for @angular/forms #631

Closed
wants to merge 2 commits into from
Closed

support for @angular/forms #631

wants to merge 2 commits into from

Conversation

jFensch
Copy link

@jFensch jFensch commented Jun 20, 2016

This PR should resolve #627. Uses the new providers/directives from @angular/forms

@Dinistro Dinistro mentioned this pull request Jun 23, 2016
@Dinistro
Copy link
Contributor

thank you very much. I will take a look at this later today.

@Dinistro
Copy link
Contributor

Dinistro commented Jun 23, 2016

@jFensch You forgot to add the @angular/forms to the .config/bundles-system.js.Can you please update this?

@valorkin This contains breaking changes. We need to make sure, that we release these changes in a 1.2.* version.

"@angular/platform-browser": "^2.0.0-rc.1",
"@angular/platform-browser-dynamic": "^2.0.0-rc.1",
"@angular/router-deprecated": "2.0.0-rc.1",
"@angular/common": "^2.0.0-rc.2",

This comment was marked as off-topic.

@valorkin
Copy link
Member

@Dinistro and rebase is must, or cherry pick at least

@Dinistro
Copy link
Contributor

@jFensch Can you please rebase your branch to resolve the conflicts?

@Dinistro
Copy link
Contributor

Dinistro commented Jul 1, 2016

@jFensch Thanks for the rebase but unfortunately some tests are not working, can you please fix them?

@jFensch jFensch closed this Jul 1, 2016
@Dinistro
Copy link
Contributor

Dinistro commented Jul 1, 2016

@valorkin Now we need to do this by our own. Unluckily I have finals on monday and so I don't have time to do it right now.

@jFensch
Copy link
Author

jFensch commented Jul 1, 2016

Recloning and fixing the tests...give me a minute.

Sorry

@kenkopelson
Copy link

Hi guys :) Any idea when the broken 1.0.17 will be fixed? I'm getting the "No provider for NgModel" also, and can't move forward with my development. Would really appreciate this being fixed.

@mpx200
Copy link

mpx200 commented Jul 7, 2016

i'm having same issue with rc4

@jprinaldi
Copy link
Contributor

Yeah, same here. Can't wait for the update.

Thanks for your hard work as always guys!

@kenkopelson
Copy link

Yes, thank you for the hard work and commitment. All of us who are using the ng-bootstrap library really do appreciate it. We would not be able to move forward with Angular 2 without it! Please let us know about the status of this breakage so we can make plans accordingly. Much appreciated :)

@valorkin
Copy link
Member

In order to use new forms you need to enable them:
https://github.com/valor-software/ng2-bootstrap/blob/development/demo/index.ts#L57-L58
and use NgModel from angular/forms

@trollr
Copy link

trollr commented Jul 12, 2016

Don't work for me. Added

disableDeprecatedForms(), provideForms(),

and used NgModel from @angular/forms. Still ORIGINAL EXCEPTION: No provider for NgModel! with ng2-bootstrap 1.0.20 for typeahead

@Dinistro
Copy link
Contributor

@trollr @valorkin i will take a look at this.

@jprinaldi
Copy link
Contributor

Just a heads up, it does work fine for me with 1.0.22.

@Dinistro
Copy link
Contributor

@trollr @juampi I forgot to add the support for typeahead inside a form...

@jprinaldi
Copy link
Contributor

Oh, I see. I didn't test typeahead.

@Dinistro
Copy link
Contributor

@trollr This PR should fix it: #723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support the RC.2 Forms
7 participants