fix: throw error and handle in catch block

valora-inc · Jun 30, 2023 · 103e6c1 · 103e6c1
1 parent 9f5fb08
commit 103e6c1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/nfts/saga.test.tsx b/src/nfts/saga.test.tsx
@@ -61,7 +61,8 @@ describe('Given Nfts saga', () => {
         ])
         .put(
           fetchNftsFailed({
-            error: 'Could not parse NFTs',
+            error:
+              'invalid json response body at  reason: Unexpected token i in JSON at position 0',
           })
         )
         .run()

diff --git a/src/nfts/saga.ts b/src/nfts/saga.ts
@@ -33,12 +33,14 @@ export function* handleFetchNfts() {
         Accept: 'application/json',
       },
     })
-    if (!response.ok) yield put(fetchNftsFailed({ error: 'Could not fetch NFTs' }))
+    if (!response.ok) {
+      throw new Error('Could not fetch NFTs')
+    }
     const { result } = yield call([response, 'json'])
     yield put(fetchNftsCompleted(result))
   } catch (error) {
-    Logger.error(TAG, 'Could not parse NFTs response', error)
-    yield put(fetchNftsFailed({ error: 'Could not parse NFTs' }))
+    Logger.error(TAG, '@handleFetchNfts', error)
+    yield put(fetchNftsFailed({ error: error.message }))
   }
 }