chore: add remote config variable for decentralised phone verification paths #3603
Conversation
src/account/Settings.tsx
Outdated
| @@ -100,6 +101,7 @@ interface StateProps { | |||
| supportedBiometryType: BIOMETRY_TYPE | null | |||
| shouldShowRecoveryPhraseInSettings: boolean | |||
| hapticFeedbackEnabled: boolean | |||
| odisV1EOL: boolean | |||
There was a problem hiding this comment.
nit: seems simpler, no?
| odisV1EOL: boolean | |
| odisV1Enabled: boolean |
There was a problem hiding this comment.
lol, yes this is better. i updated
There was a problem hiding this comment.
lol sorry, even more 2nd thoughts: decentralizedVerificationEnabled instead?
super nit 😅
There was a problem hiding this comment.
lol, i'm also fine with that. updated
src/app/saga.ts
Outdated
| @@ -384,8 +386,9 @@ export function* handleSetAppState(action: SetAppState) { | |||
| } | |||
|
|
|||
| export function* runCentralPhoneVerificationMigration() { | |||
| const odisV1EOL = yield select(odisV1EOLSelector) | |||
| const shouldRunVerificationMigration = yield select(shouldRunVerificationMigrationSelector) | |||
There was a problem hiding this comment.
nit: We should update shouldRunVerificationMigrationSelector instead and add the new condition there?
Otherwise this selector name becomes a bit misleading.
There was a problem hiding this comment.
ah oops, yes you're right. updated!
kathaypacific
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3603 +/- ##
=======================================
Coverage 81.57% 81.57%
=======================================
Files 691 691
Lines 24011 24018 +7
Branches 4261 4263 +2
=======================================
+ Hits 19586 19593 +7
Misses 4368 4368
Partials 57 57
Continue to review full report in Codecov by Sentry.
|
### Description This was a bug from #3603 :( ### Test plan manually tested ### Related issues n/a ### Backwards compatibility Y
### Description This was a bug from #3603 :( ### Test plan manually tested ### Related issues n/a ### Backwards compatibility Y
Description
When odis v1 is EOL'ed, we will no longer be able to get the phone hash using ODIS. This means we should:
Test plan
n/a
Related issues
Backwards compatibility
Y