feat(SelectProvider): add info text on amount spent #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3919 +/- ##
=======================================
Coverage 82.27% 82.28%
=======================================
Files 707 708 +1
Lines 26274 26289 +15
Branches 3579 3584 +5
=======================================
+ Hits 21618 21632 +14
- Misses 4593 4594 +1
Partials 63 63
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
satish-ravi
commented
Jun 26, 2023
| @@ -0,0 +1,50 @@ | |||
| import BigNumber from 'bignumber.js' | |||
There was a problem hiding this comment.
This is just moved from src/fiatconnect/ReviewScreen.tsx
jh2oman
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 1 of the changes to select provider screen to show receive amount instead of fees. This includes integration with statsig feature gate and showing the "You'll pay/withdraw including fees" text. Showing the receive amount will be in a follow up
Test plan
Related issues
Backwards compatibility
Yes