Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nft-thumbnail): add width to thumbnail #3925

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Jun 29, 2023

Description

It looks like #3903 was merged without adding a width to the NFT thumbnail. Since we don't have the dimentions of the images prior to fetching this causes render issues on low latency networks.

iOS Before

Screen.Recording.2023-06-29.at.8.42.23.AM.mov

iOS After

Screen.Recording.2023-06-29.at.8.49.28.AM.mov

Test plan

Tested locally on iOS and with network link conditioner to simulate poor network conditions.

Related issues

#3903

Backwards compatibility

Yes

@MuckT MuckT requested a review from kathaypacific June 29, 2023 15:58
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3925 (8ce76c1) into main (a6f8313) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3925   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files         708      708           
  Lines       26289    26289           
  Branches     3584     3584           
=======================================
+ Hits        21629    21630    +1     
+ Misses       4597     4596    -1     
  Partials       63       63           
Impacted Files Coverage Δ
src/nfts/NftsInfoCarousel.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f8313...8ce76c1. Read the comment docs.

Copy link
Collaborator

@kathaypacific kathaypacific left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@MuckT MuckT enabled auto-merge (squash) June 30, 2023 17:14
@MuckT MuckT merged commit f84ce0d into main Jun 30, 2023
15 checks passed
@MuckT MuckT deleted the tomm/nft-thumbnail-width branch June 30, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants