Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reorder the dapp featured actions cards #3930

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

kathaypacific
Copy link
Collaborator

Description

As the title - i implemented this before Reed updated the designs so the order was wrong.

Test plan

n/a

Related issues

Backwards compatibility

Y

@kathaypacific kathaypacific enabled auto-merge (squash) June 30, 2023 09:56
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #3930 (d603a62) into main (4fc118b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3930      +/-   ##
==========================================
- Coverage   82.24%   82.23%   -0.01%     
==========================================
  Files         707      707              
  Lines       26223    26223              
  Branches     3578     3578              
==========================================
- Hits        21567    21565       -2     
- Misses       4593     4595       +2     
  Partials       63       63              
Impacted Files Coverage Δ
src/dappsExplorer/DappFeaturedActions.tsx 94.87% <100.00%> (-2.57%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fc118b...d603a62. Read the comment docs.

@kathaypacific kathaypacific merged commit e846c2b into main Jun 30, 2023
15 checks passed
@kathaypacific kathaypacific deleted the kathy/dapp-actions-fix-order branch June 30, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants