feat: rework cab for onboarding flow #5611
Conversation
# Conflicts: # src/keylessBackup/SignInWithEmail.test.tsx # src/keylessBackup/SignInWithEmail.tsx
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5611 +/- ##
==========================================
- Coverage 86.72% 86.71% -0.01%
==========================================
Files 774 772 -2
Lines 31621 31591 -30
Branches 5471 5474 +3
==========================================
- Hits 27422 27394 -28
- Misses 3970 4151 +181
+ Partials 229 46 -183
... and 88 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
|
||
| const navigatedFromSettings = origin === KeylessBackupOrigin.Settings | ||
| const isOnboarding = origin === KeylessBackupOrigin.Onboarding |
There was a problem hiding this comment.
Do we need both navigatedFromSettings and isOnboarding? One being true should imply that the other is false (unless we have some plan to have a 3rd way to get to CAB).
There was a problem hiding this comment.
We don't need both, but using isOnboarding is more explicit and will keep working if we add another origin.
There was a problem hiding this comment.
don't feel too strongly on this, but looking at the component, it feels a bit arbitrary on when to use which boolean as some use expressions isOnboarding and some others use navigatedFromSettings.
There was a problem hiding this comment.
Replaced instances of navigatedFromSettings with isOnboarding and swapped the tertiaries in 221cdcc.
|
|
||
| const navigatedFromSettings = origin === KeylessBackupOrigin.Settings | ||
| const isOnboarding = origin === KeylessBackupOrigin.Onboarding |
There was a problem hiding this comment.
don't feel too strongly on this, but looking at the component, it feels a bit arbitrary on when to use which boolean as some use expressions isOnboarding and some others use navigatedFromSettings.
### Description Change cta for restore back to "Restoring your wallet", fixing a bug introduced in #5611 ### Test plan Manually restoring and checking the CTA ### Related issues N/A ### Backwards compatibility Yes ### Network scalability N/A
Description
Works to adjust the cab flow for similar styles to onboarding.
Brief Summary of Changes:
ViewwithScrollViewthroughout theKeylessBackupProgress.tsx.Test plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A