Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integration): Don't update filescope if already set #1446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ApurvBazari
Copy link

Raising the PR to get the discussion started.

Fixes Issues:-

If we try to consume a library build on Vanilla Extract which just transpiles the styles files, then this replacement of setFileScope causes issues in classNames not being consistent because the server takes from the cjs build while client takes form the esm build. This causes the hash of the classNames to differ since @vanilla-extract/integration package again updates the fileScope but differently for cjs and esm files.

I think if the fileScope is already set by the library author, then the consumer app should not be updating it again. 🤔 I may not fully understand the reason why this is done, but I'm happy to help and contribute

Copy link

changeset-bot bot commented Jul 9, 2024

⚠️ No Changeset found

Latest commit: 8aa9fce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant