Skip to content

Commit

Permalink
feat: subscription create need namespace
Browse files Browse the repository at this point in the history
Signed-off-by: xdlbdy <[email protected]>
  • Loading branch information
xdlbdy committed Mar 13, 2023
1 parent 52fb137 commit d061fc4
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions internal/controller/trigger/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,6 @@ func (ctrl *controller) CreateSubscription(ctx context.Context,
})
return nil, err
}
// subscription name can't be repeated in a namespace
eventbusID := vanus.NewIDFromUint64(request.Subscription.EventbusId)
_sub := ctrl.subscriptionManager.GetSubscriptionByName(ctx, eventbusID, request.Subscription.Name)
if _sub != nil {
return nil, errors.ErrInvalidRequest.WithMessage(
fmt.Sprintf("subscription name %s has exist", request.Subscription.Name))
}
sub := convert.FromPbSubscriptionRequest(request.Subscription)
sub.ID, err = vanus.NewID()
sub.CreatedAt = time.Now()
Expand Down Expand Up @@ -230,14 +223,6 @@ func (ctrl *controller) UpdateSubscription(ctx context.Context,
if request.Subscription.EventbusId != uint64(sub.EventbusID) {
return nil, errors.ErrInvalidRequest.WithMessage("can not change eventbus")
}
if request.Subscription.Name != sub.Name {
// subscription name can't be repeated in a namespace
_sub := ctrl.subscriptionManager.GetSubscriptionByName(ctx, sub.NamespaceID, request.Subscription.Name)
if _sub != nil {
return nil, errors.ErrInvalidRequest.WithMessage(
fmt.Sprintf("subscription name %s has exist", request.Subscription.Name))
}
}
update := convert.FromPbSubscriptionRequest(request.Subscription)
transChange := 0
if !sub.Transformer.Exist() && update.Transformer.Exist() {
Expand Down

0 comments on commit d061fc4

Please sign in to comment.