Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix metadata recover logic #337

Merged
merged 2 commits into from
Dec 13, 2022
Merged

fix: fix metadata recover logic #337

merged 2 commits into from
Dec 13, 2022

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

img_v2_2d4bb93e-df8c-43dd-b325-559b8f55f79g

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #337 (1fe51f7) into main (09f3748) will increase coverage by 0.21%.
The diff coverage is 62.25%.

❗ Current head 1fe51f7 differs from pull request most recent head 7a62e37. Consider uploading reports for the commit 7a62e37 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   62.72%   62.93%   +0.21%     
==========================================
  Files         133      143      +10     
  Lines       12128    13105     +977     
==========================================
+ Hits         7607     8248     +641     
- Misses       3977     4276     +299     
- Partials      544      581      +37     
Impacted Files Coverage Δ
internal/primitive/vanus/id.go 19.84% <0.00%> (-0.49%) ⬇️
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/raft/appender.go 0.00% <0.00%> (ø)
internal/store/block/raft/snapshot.go 0.00% <0.00%> (ø)
internal/store/block/raft/transport.go 0.00% <0.00%> (ø)
internal/store/io/file_linux.go 0.00% <0.00%> (ø)
internal/store/segment/server.go 13.32% <0.00%> (-0.11%) ⬇️
internal/store/vsb/block.go 46.34% <0.00%> (ø)
internal/store/vsb/block_seek.go 0.00% <0.00%> (ø)
internal/store/vsb/engine_open.go 3.44% <0.00%> (-0.13%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e6f9c...7a62e37. Read the comment docs.

Signed-off-by: jyjiangkai <[email protected]>
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit 9969088 into main Dec 13, 2022
@hwjiangkai hwjiangkai deleted the timerpanic branch December 13, 2022 15:06
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* fix: fix metadata recover logic

* fix: add DCO

Signed-off-by: jyjiangkai <[email protected]>

Signed-off-by: jyjiangkai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants