Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): raft support propose callback #370

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

ifplusor
Copy link
Collaborator

@ifplusor ifplusor commented Dec 28, 2022

What problem does this PR solve?

Issue Number: close #241

Problem Summary

Append events to store returns negative true when the leader node becomes a follower.

What is changed and how does it work?

Support callback for raft proposing to watch the entry is committed or dropped.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@ifplusor ifplusor changed the title feat(store): raft support commit callback feat(store): raft support propose callback Dec 28, 2022
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #370 (da439db) into main (09f3748) will increase coverage by 0.19%.
The diff coverage is 60.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   62.72%   62.91%   +0.19%     
==========================================
  Files         133      162      +29     
  Lines       12128    13512    +1384     
==========================================
+ Hits         7607     8501     +894     
- Misses       3977     4414     +437     
- Partials      544      597      +53     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 56.09% <0.00%> (ø)
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.68% <0.00%> (-0.65%) ⬇️
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/raft/appender.go 0.00% <0.00%> (ø)
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f905f...da439db. Read the comment docs.

@ifplusor ifplusor merged commit 7e5318d into vanus-labs:main Dec 28, 2022
@ifplusor ifplusor deleted the feat-raft-commit-callback branch December 28, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Append events to store returns negative true when the leader node becomes follower
2 participants