Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use T.TempDir to create temporary test directory #381

Merged
merged 2 commits into from
Jan 6, 2023
Merged

test: use T.TempDir to create temporary test directory #381

merged 2 commits into from
Jan 6, 2023

Commits on Jan 3, 2023

  1. test: use T.TempDir to create temporary test directory

    This commit replaces `os.MkdirTemp` with `t.TempDir` in tests. The
    directory created by `t.TempDir` is automatically removed when the test
    and all its subtests complete.
    
    Prior to this commit, temporary directory created using `os.MkdirTemp`
    needs to be removed manually by calling `os.RemoveAll`, which is omitted
    in some tests. The error handling boilerplate e.g.
    	defer func() {
    		if err := os.RemoveAll(dir); err != nil {
    			t.Fatal(err)
    		}
    	}
    is also tedious, but `t.TempDir` handles this for us nicely.
    
    Reference: https://pkg.go.dev/testing#T.TempDir
    Signed-off-by: Eng Zer Jun <[email protected]>
    Juneezee committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    eea9d4a View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. test: import comments

    Signed-off-by: Eng Zer Jun <[email protected]>
    Juneezee committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    72f5c9b View commit details
    Browse the repository at this point in the history