Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add functio array foreach #403

Merged
merged 10 commits into from
Jan 16, 2023
Merged

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Jan 9, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #403 (93796d5) into main (09f3748) will decrease coverage by 3.12%.
The diff coverage is 48.54%.

❗ Current head 93796d5 differs from pull request most recent head 7bb7d37. Consider uploading reports for the commit 7bb7d37 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   62.72%   59.60%   -3.13%     
==========================================
  Files         133      175      +42     
  Lines       12128    14364    +2236     
==========================================
+ Hits         7607     8561     +954     
- Misses       3977     5192    +1215     
- Partials      544      611      +67     
Impacted Files Coverage Δ
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.68% <0.00%> (-0.65%) ⬇️
internal/raft/log/recovery.go 52.27% <ø> (ø)
internal/raft/log/wal.go 100.00% <ø> (ø)
internal/store/block/entry.go 70.96% <ø> (ø)
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eea51a...7bb7d37. Read the comment docs.

@xdlbdy xdlbdy marked this pull request as draft January 16, 2023 03:19
@xdlbdy xdlbdy marked this pull request as ready for review January 16, 2023 06:12
@xdlbdy xdlbdy changed the title feat: add function foreach array feat: add functio array foreach Jan 16, 2023
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit b762f1e into vanus-labs:main Jan 16, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* feat: add function foreach array

Signed-off-by: xdlbdy <[email protected]>

* feat: add function foreach array

Signed-off-by: xdlbdy <[email protected]>

* feat: add function foreach array

Signed-off-by: xdlbdy <[email protected]>

* feat: add function foreach array

Signed-off-by: xdlbdy <[email protected]>

* feat: add function foreach array

Signed-off-by: xdlbdy <[email protected]>

* fix: ut error

Signed-off-by: xdlbdy <[email protected]>

* feat: add function foreach array

Signed-off-by: xdlbdy <[email protected]>

* feat: add function foreach array

Signed-off-by: xdlbdy <[email protected]>

* feat:  feat: add function array foreach

Signed-off-by: xdlbdy <[email protected]>

* feat:  feat: add function array foreach

Signed-off-by: xdlbdy <[email protected]>

Signed-off-by: xdlbdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants