feat: add function replace_between_positions #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
xdlbdy
changed the title
xdlbdy
reviewed
Jan 10, 2023
internal/primitive/transform/action/strings/replace_between_positions.go
Outdated
Show resolved
Hide resolved
internal/primitive/transform/action/strings/replace_between_positions_test.go
Outdated
Show resolved
Hide resolved
internal/primitive/transform/action/strings/replace_between_positions_test.go
Show resolved
Hide resolved
internal/primitive/transform/action/strings/replace_between_positions.go
Outdated
Show resolved
Hide resolved
|
I've updated the code @xdlbdy thanks to you. |
|
Do I have to sign the CLA assistant also? |
hi @c0d33ngr Yeah, please sign the CLA assistant |
xdlbdy
reviewed
Jan 10, 2023
internal/primitive/transform/action/strings/replace_between_positions_test.go
Outdated
Show resolved
Hide resolved
|
I've made updates to the code |
xdlbdy
reviewed
Jan 11, 2023
internal/primitive/transform/action/strings/replace_between_positions_test.go
Outdated
Show resolved
Hide resolved
internal/primitive/transform/action/strings/replace_between_positions_test.go
Outdated
Show resolved
Hide resolved
internal/primitive/transform/action/strings/replace_between_positions_test.go
Outdated
Show resolved
Hide resolved
|
I've updated the code |
xdlbdy
reviewed
Jan 11, 2023
internal/primitive/transform/action/strings/replace_between_positions_test.go
Outdated
Show resolved
Hide resolved
internal/primitive/transform/action/strings/replace_between_positions_test.go
Outdated
Show resolved
Hide resolved
internal/primitive/transform/action/strings/replace_between_positions_test.go
Show resolved
Hide resolved
I just saw a test earlier before you merging it about mismatch type from checks provided |
wenfengwang
pushed a commit
that referenced
this pull request
Mar 23, 2023
* implement the function replace_between_positions * Update code to be more robust with checks and test cases * fix errors in code * fix tests in replace-between-positions * Fix bug * fix: fix code error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #376
Problem Summary
This problem solve the issue of finding a sub-string by specifying the starting position and the ending position of an existed json element, and then replace it with a specific new string.
What is changed and how does it work?
Check List
Tests