Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dead letter #420

Merged
merged 4 commits into from
Feb 13, 2023
Merged

feat: dead letter #420

merged 4 commits into from
Feb 13, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Feb 10, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • create eventbus
    vsctl eventbus create eventbus --name quick-start
  • create subscription
vsctl subscription create \
--name quick-start \
--eventbus quick-start \
--sink 'http://localhost:18080' \
--ordered-event
  • put event
vsctl event put quick-start \
--data '{"id":1234,"username":"name","birthday":"2022-11-21"}' \
--id "1nd" \
--source "quick-start"
  • get dead letter
vsctl subscription dead-letter get --id 0000001241000010 --number=10
  • resend dead letter
vsctl subscription dead-letter resend --id 0000001241000010 
  • No code

@xdlbdy xdlbdy marked this pull request as draft February 10, 2023 09:54
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #420 (a1fa092) into main (2a78cb5) will decrease coverage by 0.49%.
The diff coverage is 29.11%.

❗ Current head a1fa092 differs from pull request most recent head 1d5b7ec. Consider uploading reports for the commit 1d5b7ec to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   57.71%   57.23%   -0.49%     
==========================================
  Files         180      181       +1     
  Lines       14614    14880     +266     
==========================================
+ Hits         8434     8516      +82     
- Misses       5552     5735     +183     
- Partials      628      629       +1     
Impacted Files Coverage Δ
...ernal/controller/trigger/validation/subscripton.go 69.29% <ø> (+0.85%) ⬆️
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/gateway/proxy/direct.go 73.33% <0.00%> (-5.24%) ⬇️
internal/gateway/proxy/proxy.go 24.90% <0.00%> (-0.19%) ⬇️
internal/trigger/client/gcloud_functions.go 0.00% <0.00%> (ø)
internal/trigger/client/grpc.go 0.00% <0.00%> (ø)
internal/trigger/client/http.go 0.00% <0.00%> (ø)
internal/trigger/client/interface.go 0.00% <0.00%> (-19.24%) ⬇️
internal/trigger/client/lambda.go 0.00% <0.00%> (ø)
internal/controller/trigger/controller.go 29.76% <16.00%> (-0.59%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7278759...1d5b7ec. Read the comment docs.

Signed-off-by: xdlbdy <[email protected]>
@xdlbdy xdlbdy marked this pull request as ready for review February 11, 2023 05:09
@wenfengwang wenfengwang merged commit 2c5fd4d into vanus-labs:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants