feat: implement function split from start #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdlbdy
changed the title
xdlbdy
reviewed
Mar 4, 2023
* Create replace_between_delimiters_action function * Add function for replace_between_delimiters * Add test case for replace_between_delimiters function * Register replace_between_delimiters function in init.go file * Fix syntax error in strings_function * Update replace_between_delimiters function to catch wide range of inputs * Update unit test for replace_between_delimiters function * Remove typos from contributing file * Improve replace_between_delimiter function * Add new testcase for replace_between_delimiters function * Fix and refactor replace_between_delimiter function * Update replace_between_delimiters_test * Resolve bug in replace_between_delimiter function * Fix bug in switch case for replace_between_delimiters * Fix replace_between_delimiters to pass codecov and golangci-lint checks * Refactor replace_between_delimiters function
* feat: implement function split_between_positions * minor: fix linting errors * minor: fix linting errors * feat: implement split between position according to new description * minor: fix linting errors
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
- Coverage 57.71% 57.07% -0.64%
==========================================
Files 180 190 +10
Lines 14614 15191 +577
==========================================
+ Hits 8434 8670 +236
- Misses 5552 5884 +332
- Partials 628 637 +9
Continue to review full report at Codecov.
|
xdlbdy
approved these changes
Mar 6, 2023
wenfengwang
pushed a commit
that referenced
this pull request
Mar 23, 2023
* feat: create files split_from_start.go and split_from_start_test.go * feat: add constructor NewSplitFromStartAction, register it in runtime.Init * feat: add SplitFromStart, initial code * feat: SplitFromStart with constructor redefining Execute, add main tests * feat: function replace between delimiters (#434) * Create replace_between_delimiters_action function * Add function for replace_between_delimiters * Add test case for replace_between_delimiters function * Register replace_between_delimiters function in init.go file * Fix syntax error in strings_function * Update replace_between_delimiters function to catch wide range of inputs * Update unit test for replace_between_delimiters function * Remove typos from contributing file * Improve replace_between_delimiter function * Add new testcase for replace_between_delimiters function * Fix and refactor replace_between_delimiter function * Update replace_between_delimiters_test * Resolve bug in replace_between_delimiter function * Fix bug in switch case for replace_between_delimiters * Fix replace_between_delimiters to pass codecov and golangci-lint checks * Refactor replace_between_delimiters function * feat: implement function split_between_positions (#468) * feat: implement function split_between_positions * minor: fix linting errors * minor: fix linting errors * feat: implement split between position according to new description * minor: fix linting errors * fix: update how split_from_start handles special cases, update unit tests --------- Co-authored-by: Jeffrey Whewhetu <[email protected]> Co-authored-by: soumyadeep589 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #445
Problem Summary
The function is used to scan the source JSON path from left to right, split it into an array of two sub-strings from the given numeric position of the character, and assign the array to a target JSON path. The character of the position should be included in the first sub-string (from left to right).
What is changed and how does it work?
Check List
Tests