Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change api eventbus name to eventbus id #500

Merged
merged 5 commits into from
Mar 8, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Mar 8, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #500 (515fb50) into main (ee76217) will decrease coverage by 0.01%.
The diff coverage is 58.88%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   57.07%   57.06%   -0.01%     
==========================================
  Files         190      191       +1     
  Lines       15191    15291     +100     
==========================================
+ Hits         8670     8726      +56     
- Misses       5884     5928      +44     
  Partials      637      637              
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 52.63% <ø> (ø)
internal/controller/eventbus/block/selector.go 100.00% <ø> (ø)
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/config.go 61.11% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/primitive/cel/cel.go 68.57% <0.00%> (ø)
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722eac9...515fb50. Read the comment docs.

Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenfengwang wenfengwang merged commit 25433c4 into vanus-labs:main Mar 8, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
* feat: eventbus name change to id

Signed-off-by: xdlbdy <[email protected]>

* feat: eventbus name change to id

Signed-off-by: xdlbdy <[email protected]>

* feat: eventbus name change to id

Signed-off-by: xdlbdy <[email protected]>

* feat: eventbus name change to id

Signed-off-by: xdlbdy <[email protected]>

* feat: eventbus name change to id

Signed-off-by: xdlbdy <[email protected]>

---------

Signed-off-by: xdlbdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants