Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom configuration item #552

Merged
merged 1 commit into from
Mar 18, 2023
Merged

feat: add custom configuration item #552

merged 1 commit into from
Mar 18, 2023

Conversation

hwjiangkai
Copy link
Contributor

What problem does this PR solve?

image

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #552 (1618772) into main (ee76217) will decrease coverage by 1.26%.
The diff coverage is 46.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   57.07%   55.82%   -1.26%     
==========================================
  Files         190      191       +1     
  Lines       15191    15532     +341     
==========================================
  Hits         8670     8670              
- Misses       5884     6215     +331     
- Partials      637      647      +10     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 35.93% <0.00%> (-16.70%) ⬇️
internal/controller/eventbus/block/selector.go 91.66% <ø> (-8.34%) ⬇️
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/controller/trigger/worker/policy.go 100.00% <ø> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/primitive/cel/cel.go 68.57% <0.00%> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/queue/queue.go 87.87% <ø> (ø)
internal/primitive/transform/action/action.go 11.94% <ø> (ø)
... and 70 more

... and 39 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9db021...1618772. Read the comment docs.

@wenfengwang wenfengwang merged commit a32bfce into main Mar 18, 2023
wenfengwang pushed a commit that referenced this pull request Mar 23, 2023
@hwjiangkai hwjiangkai deleted the config branch March 24, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants