Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: unify json lib #579

Merged
merged 2 commits into from
Apr 10, 2023
Merged

feat!: unify json lib #579

merged 2 commits into from
Apr 10, 2023

Conversation

xdlbdy
Copy link
Contributor

@xdlbdy xdlbdy commented Mar 27, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #579 (e91168c) into main (ee76217) will decrease coverage by 2.52%.
The diff coverage is 45.59%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   57.07%   54.55%   -2.52%     
==========================================
  Files         190      211      +21     
  Lines       15191    17032    +1841     
==========================================
+ Hits         8670     9292     +622     
- Misses       5884     7036    +1152     
- Partials      637      704      +67     
Impacted Files Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/gateway/proxy/auth.go 0.00% <0.00%> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/gateway/proxy/direct.go 15.84% <ø> (-57.50%) ⬇️
internal/gateway/proxy/proxy.go 23.23% <ø> (+0.14%) ⬆️
internal/gateway/proxy/reigister.go 100.00% <ø> (ø)
internal/gateway/proxy/util.go 0.00% <ø> (ø)
...nternal/primitive/authentication/authentication.go 34.09% <ø> (ø)
internal/primitive/authentication/client.go 0.00% <ø> (ø)
internal/primitive/authorization/action.go 0.00% <ø> (ø)
... and 73 more

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba347ae...e91168c. Read the comment docs.

@xdlbdy xdlbdy force-pushed the remove_gjson branch 2 times, most recently from 5763436 to a310460 Compare March 28, 2023 06:21
pkg/errors/errors.go Outdated Show resolved Hide resolved
pkg/errors/errors.go Outdated Show resolved Hide resolved
pkg/errors/errors.go Outdated Show resolved Hide resolved
internal/primitive/cel/cel.go Show resolved Hide resolved
internal/primitive/cel/cel.go Outdated Show resolved Hide resolved
Signed-off-by: xdlbdy <[email protected]>
@ifplusor ifplusor changed the title feat: remove gjson and use one json lib feat!: unify json lib Apr 10, 2023
@ifplusor ifplusor merged commit 4d30541 into vanus-labs:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants