Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export With and Output of logger #593

Merged
merged 1 commit into from
Apr 6, 2023
Merged

feat: export With and Output of logger #593

merged 1 commit into from
Apr 6, 2023

Conversation

ifplusor
Copy link
Collaborator

@ifplusor ifplusor commented Apr 6, 2023

What problem does this PR solve?

Issue Number: None

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

wenfengwang
wenfengwang approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@wenfengwang wenfengwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifplusor ifplusor merged commit c0d1f44 into vanus-labs:main Apr 6, 2023
@ifplusor ifplusor deleted the log-with branch April 6, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenfengwang wenfengwang wenfengwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifplusor @wenfengwang