Skip to content

Commit

Permalink
(AllenFang#838) Limited react version to avoid toastr failure.
Browse files Browse the repository at this point in the history
  • Loading branch information
vapon committed Nov 22, 2016
1 parent 7c8a3c2 commit 6a627e9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@
"history": "^1.17.0",
"jquery": "^2.1.4",
"jsx-loader": "^0.13.2",
"react": "^0.14.3 || ^15.0.0",
"react": "^0.14.3 || <15.4.0",
"react-bootstrap": "^0.29.5",
"react-dom": "^0.14.3 || ^15.0.0",
"react-dom": "^0.14.3 || <15.4.0",
"react-hot-loader": "^1.3.0",
"react-router": "^1.0.2",
"style-loader": "^0.13.0",
Expand All @@ -65,10 +65,10 @@
},
"dependencies": {
"classnames": "^2.1.2",
"react-toastr": "2.8.0"
"react-toastr": "https://github.com/vapon/react-toastr.git"
},
"peerDependencies": {
"react": "^0.14.3 || ^15.0.0"
"react": "^0.14.3 || <15.4.0"
},
"jest": {
"scriptPreprocessor": "<rootDir>/preprocessor.js",
Expand Down

2 comments on commit 6a627e9

@AllenFang
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vapon, I think just change the react-toastr to your fork repo is well. dont narrow down the react version?!

@vapon
Copy link
Owner

@vapon vapon commented on 6a627e9 Nov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllenFang,
Hi, was just experimenting and couldn't get it work without narrowing react version as well. The best way is to get related react-toastr AllenFang#86 issue fixed (it was opened 6 days ago) and released.

Please sign in to comment.