Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily avoid matching on label #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

topiaruss
Copy link

Don't merge
Just for discussion...

Related to

On my minikube local cluster, I have never seen the labels match, so this selector means I never get any pods returned.

I've removed the selector and seem to be making progress setting up tests. If I can get a bit further along, I'll come back and see if I can contribute a proper solution.

@topiaruss topiaruss marked this pull request as ready for review September 22, 2019 17:29
@edaniszewski
Copy link
Contributor

Yeah, the kubetest selector that gets set was meant to be a temporary solution. Ideally, I think what we'd want is to traverse a Pod's Owner Reference up to the deployment, e.g.

I had tried that in the past, but the Kubernetes Python client felt limiting around that, particularly because the traversal may have multiple steps and I couldn't find a good way of looking up an object by its UID surprisingly. I may take another pass through the client code to see if I can come closer to a good solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants