Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set VCID's range from 1 to 4294967295 #28

Merged
merged 4 commits into from
Jul 21, 2020
Merged

Set VCID's range from 1 to 4294967295 #28

merged 4 commits into from
Jul 21, 2020

Conversation

hoanhan101
Copy link
Contributor

Fixes #23

marcoceppi
marcoceppi reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@marcoceppi marcoceppi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to generate a migration?

@hoanhan101
Copy link
Contributor Author

@marcoceppi Yes, it does. Just added the migration file in the last commit!

@marcoceppi marcoceppi merged commit 571ecb1 into master Jul 21, 2020
@hoanhan101 hoanhan101 deleted the vcid-size branch September 22, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoceppi marcoceppi marcoceppi approved these changes

@jinaloo7 jinaloo7 Awaiting requested review from jinaloo7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VCID modeling problem
2 participants
@hoanhan101 @marcoceppi