Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elide main queue check in Linux readpassphrase() implementation #185

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Aug 29, 2023

In an async world, the check for running on the main queue in linux_readpassphrase() is hopelessly wrong. Since it's a violation of the API contract to call this method from multiple threads, we just remove the bad assertion and let misuse fail out the same way the "real" API would.

Fixes #184.

@gwynne gwynne added the semver-patch When merged, a new patch version release will be generated label Aug 29, 2023
@gwynne gwynne requested a review from MahdiBM August 29, 2023 20:10
@gwynne gwynne requested a review from 0xTim as a code owner August 29, 2023 20:10
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #185 (d9f404f) into main (cc584bd) will decrease coverage by 0.11%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   49.01%   48.91%   -0.11%     
==========================================
  Files          45       45              
  Lines        1887     1887              
==========================================
- Hits          925      923       -2     
- Misses        962      964       +2     
Files Coverage Δ
...ces/ConsoleKit/Terminal/readpassphrase_linux.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@gwynne gwynne enabled auto-merge (squash) November 4, 2023 15:42
@gwynne gwynne merged commit f4ef965 into main Nov 4, 2023
13 checks passed
@gwynne gwynne deleted the gwynne-patch-1 branch November 4, 2023 15:48
@penny-for-vapor
Copy link

These changes are now available in 4.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch When merged, a new patch version release will be generated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when using Secure Input in Docker container for custom Vapor Command
3 participants