Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DocC Links #204

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix DocC Links #204

merged 1 commit into from
Oct 10, 2024

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Oct 10, 2024

Fixes the DocC link in the umbrella module. This works around DocC injecting in the base path to any non-fully qualified links.

Resolves #203

@0xTim 0xTim requested a review from gwynne as a code owner October 10, 2024 09:41
@gwynne gwynne merged commit 1490e7b into main Oct 10, 2024
11 checks passed
@gwynne gwynne deleted the 0xTim-patch-1 branch October 10, 2024 15:56
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.44%. Comparing base (78c0dd7) to head (ade7659).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   54.26%   54.44%   +0.18%     
==========================================
  Files         103      103              
  Lines        4515     4476      -39     
==========================================
- Hits         2450     2437      -13     
+ Misses       2065     2039      -26     

see 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Api docs links are wrong on the API website
2 participants