Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Singapore dollar sign to 'S$' #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

taufik-rama
Copy link

Hello 👋

I'm currently using the library, and I think I found a case where a currency symbol is ambiguous.

For Singapore currency sign, I think it can be changed from just $ to S$ (wikipedia), since currently I'm supporting both the USD & SGD currency, and it's kinda confusing when both are displayed

The sign symbol seems to be outside of the scope of the ISO, so I'm guessing it's fine since there doesn't seem to be any standard for it

@varunsrin
Copy link
Owner

If we're doing this, it should be done consistently across all colliding currencies otherwise it leads to some inconsistent behaviors.

@taufik-rama
Copy link
Author

I don't have much to say regarding other currencies, that might take some work/discussion for sure!

To me, I'd like the open-source approach of letting other people that benefit from this library to contribute, since I don't know what's best for other people that uses the currencies might expect

All in all it's not an urgent changes though, since it might be too specific for my usecase. I'm fine with closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants