Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some unit tests #26

Closed
wants to merge 10 commits into from
Closed

Fix some unit tests #26

wants to merge 10 commits into from

Conversation

seananderson
Copy link
Collaborator

Suppress some warnings. Make sure tests aren't missing an expectation. Make sure packages loaded. Needed for coverage checks (although there might be other issues too).

@James-Thorson-NOAA
Copy link
Collaborator

Thanks Sean!

After thinking a bit, I'm gonna instead do a PR from your branch into my current branch add_header, resolve the conflicts by prioritizing your versions in those files that you changed, and see if that still passes checks. Feel free to tell me if you see a better way to do this, I'm still learning about how best to use github collaboratively with multiple developers.

@James-Thorson-NOAA
Copy link
Collaborator

I merged this to add_header which is my current dev branch. I'm trying to sort the stream-network example, which is causing the pkgdown to fail on Actions, although it runs locally. Anyway, I'm gonna close this for now, but the changes will go to main when I merge add_header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants