Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xen-api): add an HTTP proxy support #5958

Merged
merged 9 commits into from
Oct 27, 2021

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Oct 20, 2021

connecting to an HTTPS xen api with its api show this warning DeprecationWarning: Setting the TLS ServerName to an IP address is not permitted by RFC 6066.

The corresponding issue is there : TooTallNate/proxy-agents#127

New field in the server UI (edit and add)
image

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp force-pushed the florent-xenapi-support_http_proxy branch 2 times, most recently from a45bd6f to 8856192 Compare October 20, 2021 13:03
@fbeauchamp fbeauchamp changed the title wip: feat(xen-api): add an http proxy for xen api feat(xen-api): add an http proxy for xen api Oct 22, 2021
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@julien-f julien-f requested a review from pdonias October 25, 2021 09:03
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/settings/servers/index.js Outdated Show resolved Hide resolved
@julien-f julien-f removed their request for review October 27, 2021 09:00
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@julien-f julien-f changed the title feat(xen-api): add an http proxy for xen api feat(xen-api): add an HTTP proxy support Oct 27, 2021
@julien-f
Copy link
Member

Please fix conflicts for the merge.

@fbeauchamp fbeauchamp force-pushed the florent-xenapi-support_http_proxy branch from 3f84f43 to be4c7b6 Compare October 27, 2021 15:23
@julien-f julien-f merged commit 2412f8b into master Oct 27, 2021
@julien-f julien-f deleted the florent-xenapi-support_http_proxy branch October 27, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants