Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker container runs thor under new user #575

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

kgapos
Copy link
Member

@kgapos kgapos commented Mar 29, 2023

docker runs the node though a new thor user, following the slowmist security guidelines, instead of the current implementation, which runs it under root

@kgapos
Copy link
Member Author

kgapos commented Mar 29, 2023

This is a minor improvement, I suppose the blast radius is already limited by docker. I was more interested in trying out the contribution process. I welcome any and all feedback, feel free to merge this (or not) :shipit:

Dockerfile Outdated Show resolved Hide resolved
@libotony
Copy link
Member

libotony commented Apr 4, 2023

Thanks! Looks good to me, I'll test locally

@libotony
Copy link
Member

libotony commented Apr 7, 2023

Wasted some on my local container runtime colima which has some problems of mounted volume, Docker Desktop for mac and docker engine on linux works fine.

@libotony libotony merged commit 5799eff into vechain:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants